Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8916: Content update in User documentation - cd. #314

Merged
merged 18 commits into from
Oct 21, 2024
Merged

IBX-8916: Content update in User documentation - cd. #314

merged 18 commits into from
Oct 21, 2024

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Sep 25, 2024 •
edited
Loading

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-8916)
Versions 4.6+

Content update in User documentation

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Added link to this PR in relevant JIRA ticket or code PR

@julitafalcondusza julitafalcondusza marked this pull request as ready for review September 27, 2024 07:55
dabrt
dabrt reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

docs/commerce/shipping_management/work_with_shipping_methods.md Outdated Show resolved Hide resolved
docs/content_management/configure_ct_field_settings.md Outdated Show resolved Hide resolved
docs/content_management/configure_ct_field_settings.md Outdated Show resolved Hide resolved
docs/content_management/configure_ct_field_settings.md Outdated Show resolved Hide resolved
docs/content_management/configure_ct_field_settings.md Outdated Show resolved Hide resolved
docs/website_organization/work_with_sites.md Outdated Show resolved Hide resolved
docs/website_organization/work_with_sites.md Outdated Show resolved Hide resolved
docs/website_organization/work_with_sites.md Outdated Show resolved Hide resolved
docs/website_organization/work_with_sites.md Outdated Show resolved Hide resolved
docs/content_management/create_edit_content_items.md Outdated Show resolved Hide resolved
mnocon
mnocon approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of minor comments - not all are strictly related to your changes, but they are pretty small and I think it's a good opportunity to fix them (if you agree with them)

README.md Outdated Show resolved Hide resolved
docs/search_engine_optimization/work_with_seo.md Show resolved Hide resolved
docs/pim/work_with_catalogs.md Outdated Show resolved Hide resolved
docs/content_management/img/page blocks_toolbox.png Outdated Show resolved Hide resolved
docs/pim/work_with_product_categories.md Outdated Show resolved Hide resolved
docs/content_management/publish_instantly.md Outdated Show resolved Hide resolved
docs/content_management/schedule_publishing.md Outdated Show resolved Hide resolved
docs/content_management/schedule_publishing.md Outdated Show resolved Hide resolved
docs/content_management/workflow_management/work_with_versions.md Outdated Show resolved Hide resolved
docs/customer_management/build_customer_portal.md Outdated Show resolved Hide resolved
dabrt
dabrt approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. I merely suggested ways to handle "using"

README.md Outdated Show resolved Hide resolved
docs/commerce/payment/work_with_payment_methods.md Outdated Show resolved Hide resolved
docs/commerce/payment/work_with_payment_methods.md Outdated Show resolved Hide resolved
docs/commerce/shipping_management/work_with_shipping_methods.md Outdated Show resolved Hide resolved
docs/commerce/shipping_management/work_with_shipping_methods.md Outdated Show resolved Hide resolved
docs/image_management/edit_images.md Outdated Show resolved Hide resolved
docs/permission_management/permission_system.md Outdated Show resolved Hide resolved
docs/permission_management/permission_system.md Outdated Show resolved Hide resolved
docs/personalization/integrate_scenario_results.md Outdated Show resolved Hide resolved
docs/personalization/personalization.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@julitafalcondusza julitafalcondusza merged commit 2b18e53 into master Oct 21, 2024
5 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-8916cd branch October 21, 2024 09:52
julitafalcondusza added a commit that referenced this pull request Oct 30, 2024
@julitafalcondusza
IBX-8916: Content update in User documentation - cd. (#314)
9c2a890 
* Fixes after review

* Capitalization fixes

* Capitalization fixes

* Capitalization fixes

* Content fixes

* Capitalization & vale fixes

* Fixes - toolbox, elements

* New batch of fixes

* Screenshot added

* Fixes after review

* Fixes

* Fixes after review

* Fixes

* Fixes

* Fixes

* Fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrt dabrt dabrt approved these changes

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julitafalcondusza @mnocon @dabrt